This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] AArch64 - Add parameter to __mount routine
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Cc: libc-ports at sourceware dot org, Patch Tracking <patch at linaro dot org>
- Date: Mon, 16 Sep 2013 12:31:02 +0100
- Subject: Re: [PATCH] AArch64 - Add parameter to __mount routine
- Authentication-results: sourceware.org; auth=none
- References: <CAJK_mQ2OQPP7_RFcMJc2NP7Wz7hX2AHQ9aVb8-uKi+MZN4UFsA at mail dot gmail dot com>
On 15 September 2013 13:45, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Maintainers,
>
> Attached is a small patch which adds a parameter to __mcount routine.
>
> We would like to make the compiler pass the "frompc" address from the function
> that calls __mcount during profiling.
This is an ABI change, however, given that there is no functioning
profiling solution using the existing interface I don't think that
such a change is a problem. Does anyone object?
> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>
> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>
> If it is ok, someone please commit on my behalf.
No regressions is a good start. How did you test the the combined
gcc/glibc patches for profiling are working correctly?
/Marcus