This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [Patch, mips] Faster strcmp for mips
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>
- Date: Fri, 15 Nov 2013 13:47:52 -0500
- Subject: Re: [Patch, mips] Faster strcmp for mips
- Authentication-results: sourceware.org; auth=none
- References: <1384464221 dot 2484 dot 86 dot camel at ubuntu-sellcey>
On Thu, Nov 14, 2013 at 4:23 PM, Steve Ellcey <sellcey@mips.com> wrote:
> This means it could be loading bytes beyond the end of the strings being
> compared but it looks like other architecture specific strcmp functions
> are also doing this optimization and the newlib version of strcmp also does
> this.
I thought that doing so was dangerous? I'm pretty sure we've been trying
to fix such "load bytes beyond the end of the string" issues because you
could have a string that straddles a page boundary with the next page
unmapped and such an optimized routine would fault on a read from the
unmapped page.
How do you plan to fix that?
Cheers,
Carlos.