This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] 2nd round of Mips ifunc support


On 16 November 2013 00:41, Jack Carter <Jack.Carter@imgtec.com> wrote:
> Attached is the second pass for Mips ifunc support in glibc.
>
> There is an abi attached as well.

Your patch would be easier to review if it was posted inline with e.g.
git-send-email.

I don't think the vxworks comment in the commit message (or indeed the
reference to micromips etc.) makes any sense in the context of glibc.

The use of __builtin_expect should be replaced with __glibc_unlikely.

The example in your ABI doc should probably take an argument of the
hwcap value rather than void.

-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]