This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] 2nd round of Mips ifunc support
- From: Will Newton <will dot newton at linaro dot org>
- To: Jack Carter <Jack dot Carter at imgtec dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, "rdsandiford at googlemail dot com" <rdsandiford at googlemail dot com>
- Date: Sat, 16 Nov 2013 11:06:22 +0000
- Subject: Re: [PATCH] 2nd round of Mips ifunc support
- Authentication-results: sourceware.org; auth=none
- References: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516140 at BADAG02 dot ba dot imgtec dot org>
On 16 November 2013 00:41, Jack Carter <Jack.Carter@imgtec.com> wrote:
> Attached is the second pass for Mips ifunc support in glibc.
>
> There is an abi attached as well.
Your patch would be easier to review if it was posted inline with e.g.
git-send-email.
I don't think the vxworks comment in the commit message (or indeed the
reference to micromips etc.) makes any sense in the context of glibc.
The use of __builtin_expect should be replaced with __glibc_unlikely.
The example in your ABI doc should probably take an argument of the
hwcap value rather than void.
--
Will Newton
Toolchain Working Group, Linaro