This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] PAGE_SIZE definition for MIPS XLP
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Andrew Stubbs <ams at codesourcery dot com>, <libc-ports at sourceware dot org>
- Date: Tue, 19 Nov 2013 20:19:11 +0000
- Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP
- Authentication-results: sourceware.org; auth=none
- References: <528A0813 dot 10005 at codesourcery dot com> <mvm38mtlvpj dot fsf at hawking dot suse dot de>
On Mon, 18 Nov 2013, Andreas Schwab wrote:
> > The attached patch makes the definition conditional, rather than removing
> > it completely. It's not clear to me whether the HOST_* definitions are
> > similarly affected, but other platforms that do not define PAGE_SIZE also
> > choose not to define those, so I've extended the ifndef similarly.
>
> These definitions are used by gdb for trad-core support. Does MIPS
> support trad-core?
I don't think it does, not at least on Linux where ELF has been ever used
only (and ECOFF compatibility ABI never implemented), but as a side note
trad-core has this:
#ifndef NBPG
# define NBPG getpagesize()
#endif
so it seems to be broken anyway for non-native cases. I'd expect the page
size in a core file to match that used by the kernel while the process was
still alive, so it would have to be figured out from the core binary being
handled somehow if at all possible; otherwise a user-supplied parameter.
Maciej