This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-memcpy-fix] ARM: Fix memcpy computed-jump calculations for ARM_ALWAYS_BX case.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Fri, 22 Nov 2013 13:37:51 +0000
- Subject: Re: [PATCH roland/arm-memcpy-fix] ARM: Fix memcpy computed-jump calculations for ARM_ALWAYS_BX case.
- Authentication-results: sourceware.org; auth=none
- References: <20131122024219 dot 836FC7469E at topped-with-meat dot com>
On Thu, 21 Nov 2013, Roland McGrath wrote:
> I flubbed the first version (and its testing!) of this, so it worked in the
> synthetic situation on GNU/Linux as I was testing, but did not work in the
> actual Native Client situation that motivated the change. For this fix I
> tested on arm-linux-gnueabi with arm-features.h hacked to define
> ARM_BX_ALIGN_LOG2 to 4, define ARM_ALWAYS_BX and ARM_NO_INDEX_REGISTER, and
> define 'bx' as a macro for 'nop;bx' to simulate the Native Client build
> where it's defined as a macro that expands to two instructions. The last
> hack (the 'bx' macro) is what was missing in my testing of the original
> version; testing the trunk code with that hack demonstrated the bug.
>
> OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com