This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Cc: libc-ports at sourceware dot org, Patch Tracking <patch at linaro dot org>
- Date: Mon, 30 Dec 2013 22:20:48 +0000
- Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
- Authentication-results: sourceware.org; auth=none
- References: <CAJK_mQ0EoE+_JQvSL+5=C_+Q6JgsV8hvXipy8OgR8+GYyYgt3A at mail dot gmail dot com> <52BC8489 dot 9040307 at twiddle dot net> <CAJK_mQ1GeEf4MjMBcijmwKef33kZEmoHkJv8xgqX5=k4_t9YPg at mail dot gmail dot com> <52BD983C dot 5050006 at twiddle dot net> <CAJK_mQ2mH9gE3_65S00Jg7ov1c6fWD8QFhoaxJY35pVyfAXY_Q at mail dot gmail dot com>
Hi, Couple of nits:
On 30 December 2013 05:00, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
+# define PTR_MANGLE(dst, src, guard, tmp) \
+ LDST_PCREL(ldr, guard, tmp, C_SYMBOL_NAME(__pointer_chk_guard_local)); \
+ PTR_MANGLE2(dst, src, guard)
Space before ( in macro invocations.
+#ifdef PTR_DEMANGLE
+ PTR_DEMANGLE (sp);
+#endif
Nested #if should have indentation between # and if.
+/* Pointer mangling is support for AArch64. */
support -> supported
Otherwise OK
/Marcus