This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ARM: Add SystemTap probes to longjmp and setjmp.


On 28 January 2014 21:35, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Mon, 27 Jan 2014, Will Newton wrote:
>
>> @@ -50,6 +48,11 @@ ENTRY (__longjmp)
>>       ldr     sp, [ip], #4
>>       ldr     lr, [ip], #4
>>  #endif
>> +     /* longjmp probe expects longjmp first argument (4@r0), second
>> +        argument (-4@r1), and target address (4@r14), respectively.  */
>> +     LIBC_PROBE (longjmp, 3, 4@r0, -4@r1, 4@r14)
>
> The discussion on libc-alpha said this probe should be before unwinding;
> shouldn't that mean before sp and lr are restored, so that at probe time
> it's still possible to unwind through the caller of longjmp?

Yep, I'm working on an updated patch.

-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]