This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH, COMMITTED] [MicroBlaze BZ #15705] Define MMAP2_PAGE_SHIFT
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: David Holsgrove <david dot holsgrove at xilinx dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Wed, 5 Feb 2014 16:50:03 +0000
- Subject: Re: [PATCH, COMMITTED] [MicroBlaze BZ #15705] Define MMAP2_PAGE_SHIFT
- Authentication-results: sourceware.org; auth=none
- References: <e3b9efe0-f5a8-422a-87bb-a89b6ff9b4c2 at TX2EHSMHS011 dot ehs dot local>
On Wed, 5 Feb 2014, David Holsgrove wrote:
> +/* Microblaze kernel has PAGE_SHIFT set to 12.
> + Determine the shift dynamically with getpagesize. */
The comment "has PAGE_SHIFT set to 12" seems inaccurate. The reason you
need to determine it dynamically is that the kernel
(arch/microblaze/include/asm/page.h) may define it to any of 12, 14 or 16,
depending on configuration options. If it were constant, you could just
use a suitable constant value here instead of -1.
--
Joseph S. Myers
joseph@codesourcery.com