This is the mail archive of the libffi-discuss@sources.redhat.com mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: your patch broke darwin libffi




Bryce McKinlay wrote:
> 
> David Edelsohn wrote:
> 
> >>>>>>Bryce McKinlay writes:
> >>>>>>
> >
> >Bryce> Wouldn't it be better to give this function the same name in both aix.S
> >Bryce> and darwin.S, since only one of them gets built?
> >
> >       I was trying to add the support with as little intrusion as
> >necessary while utilizing the similarities.  Darwin is not AIX and AIX is
> >not Darwin.  What name would you suggest?  During our last discussion, no
> >one could find a common name.
> >
> 
> I don't see any reason why the platform/ABI name has to be in the
> function name. How about simply ffi_call_inner or ffi_call_asm?

What about this one? It works on my darwin book, does it work with AIX
as well David?
Does it make sense? Would it be worth to go one step further and replace
the ffi_call_SYSV as well?

Regards,
Andreas

Attachment: libffi.patch
Description: Document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]