This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch libffi]: Fix _ffi_call_win64 stack allocation

From: Anthony Green <green at redhat dot com>
To: Kai Tietz <ktietz70 at googlemail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org, Andrew Haley <aph at redhat dot com>
Date: Mon, 28 Sep 2009 17:20:11 -0400
Subject: Re: [patch libffi]: Fix _ffi_call_win64 stack allocation
References: <90baa01f0909281141u78e00148k1d5e7d52be4581c4@mail.gmail.com>

Kai Tietz wrote:

Hello,

this patch fixes a stack allocation bug in _ffi_call_win64. The issue
is that the stack was one time allocated by ___chkstk and then again
stack was probed and allocated by a random value of %rax. Gcc's
___chkstk isn't the same as VC's. VC's version just probes the given
size in %rax on stack, but doesn't allocate it, but gcc's version
probes and allocates. Also VC's version doesn't clobber any register,
but gcc's version clobbers rax, r10, and r11. For more details see
gcc/config/i386/cygwin.asm file.

ChangeLog

2009-09-28 Kai Tietz <kai.tietz@onevision.com>

	* src/x86/win64.S (_ffi_call_win64 stack): Remove for gnu
	assembly version use of ___chkstk.

Tested for x86_64-pc-mingw32 without regressions. Ok for apply?

Yes, thanks.

AG

Kai

Follow-Ups:
- Re: [patch libffi]: Fix _ffi_call_win64 stack allocation
  - From: Kai Tietz

References:
- [patch libffi]: Fix _ffi_call_win64 stack allocation
  - From: Kai Tietz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]