This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: java-patches at gcc dot gnu dot org, libffi-discuss at sourceware dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 Jul 2012 20:44:00 +0200
- Subject: Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32
- References: <20120716201408.GA5091@intel.com> <20120718162727.GA23420@intel.com>
On Wed, Jul 18, 2012 at 6:27 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32.
>> It fixed:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982
>
> Here is the patch with updated ChangeLog entry. X32 has the same issue
> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html
> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html
>
> The same fix is needed for x32. OK for trunk?
>
> 2012-07-16 H.J. Lu <hongjiu.lu@intel.com>
>
> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for
> x32.
> (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32.
How did you tested this patch? Does it fix all the problems from
PR53982, including the one that is not 100% reproducible?
Uros.