This is the mail archive of the mauve-discuss@sources.redhat.com mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Mauve patch


>>>>> "Archie" == Archie Cobbs <archie@dellroad.org> writes:

Archie> This patch doesn't guarantee anything, and in general it's impossible
Archie> to make this test "correct" because the spec allows finalization and
Archie> reference enqueuing to happen after arbitrarily long delays.

Yeah, these tests are basically bogus.  I thought I had removed them,
but I guess I forgot.

Archie> This patch simply makes the test "correct" for JC (and possibly
Archie> some other VM(s) out there). Since there's no way to *ensure* the
Archie> finalizer and reference enqueing thread(s) have run, we just try
Archie> to give them every opportunity to do so before declaring that their
Archie> work should be done.

I think the patch is fine to go in.  It certainly doesn't make the
situation any worse.

Perhaps it is better to just remove the test.  Or make a new
"unportable" section of Mauve, since some things seemingly can't be
tested.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]