Re: patch: parentheses and remaining prototypes

["J. Johnston" <jjohnstn at cygnus dot com>]

Werner Almesberger wrote:
> 
> As promised, the parentheses cleanup. I've also fixed a few remaining
> prototype issues. I didn't change things where I couldn't find a
> simple solution (e.g. getpass.c vs. sig* - see also my "odd bits"
> posting), or where the nicer code would compile into worse assembler
> (strcpy.c; could be worked around by using while ((...)), but I
> strongly dislike this particular idiom).
> 
> That's all for now.
> 
> - Werner

Patch has been checked in.

-- Jeff Johnston (Red Hat Inc.)

> 
> ---------------------------------- ChangeLog ----------------------------------
> 
> 2000-08-23  Werner Almesberger  <Werner.Almesberger@epfl.ch>
>         * libc/stdlib/mprec.c (ulp, b2d, d2b): changed a few expressions
>         like  x << y-z  to the equivalent  x << (y-z)
>         * libc/stdlib/mprec.c (d2b): changed  if (y = d1) { ... to
>         if (d1) { y = d1; ...  and likewise for  if (k = lo0bits ...
>         * libc/reent/reent.c: included stdlib.h for "_free_r" prototype
>         * libc/unix/getpass.c (getpass): moved "echo" assignment out of if
>         * libc/unix/ttyname.c: included string.h for "strcpy" prototype
>         * libc/unix/getcwd.c (ISDOT): added parentheses to clarify && and ||
>         precedence
>         * libc/include/sys/unistd.h: added "vfork" prototype (for popen.c)
>         * libc/include/sys/unistd.h: added "_execve" prototype (for execl.c,
>         execle.c, execv.c, and execve.c)
>         * libc/posix/popen.c (popen): added parentheses to clarify && and ||
>         precedence
>         * libm/math/e_cosh.c (__ieee754_cosh): changed parentheses to
>         clarify && and || precendence (and to remove pascalism)
>         * libm/math/e_sinh.c (__ieee754_sinh): idem
>         * libm/math/s_infconst.c: added another pair of braces to all
>         initializers for __infinity (need three: for __infinity[1] array,
>         for union __dmath, and for i[2])
> 
> ------------------------------------ patch ------------------------------------
>