This is the mail archive of the newlib@sources.redhat.com mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: libc/string/strrchr.c

To: DJ Delorie <dj at delorie dot com>
Subject: Re: libc/string/strrchr.c
From: Christopher Faylor <cgf at redhat dot com>
Date: Fri, 4 May 2001 11:39:35 -0400
Cc: newlib at sources dot redhat dot com, earnie_boyd at yahoo dot com
References: <3AF1EB53.4EE0661@yahoo.com> <200105040013.UAA05201@envy.delorie.com>

On Thu, May 03, 2001 at 08:13:31PM -0400, DJ Delorie wrote:
>
>> 2001-05-03  Earnie Boyd  <earnie@users.sourceforge.net>
>> 
>> 	* libc/string/strrchr.c: Use strchr for the speed improvements.
>
>Perhaps you could contribute an i386-specific assembler version of
>strrchr?  That should be even faster, and will benefit all i386
>systems.

I'm working on one now.  It will be cygwin-specific, though.  I'd like
to make it an inline function.

I appreciate that Earnie has detected a bottleneck but I think that
inline assembly will be the way to go.

In my tests this gives an immediate 6 - 7% performance improvement.

Regardless, I think that the newlib change is still a good idea.

cgf

References:
- libc/string/strrchr.c
  - From: Earnie Boyd
- Re: libc/string/strrchr.c
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]