This is the mail archive of the
newlib@sources.redhat.com
mailing list for the newlib project.
Re: Fixes for mmix-knuth-mmixware
- From: "J. Johnston" <jjohnstn at redhat dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: newlib at sources dot redhat dot com
- Date: Tue, 12 Feb 2002 19:06:33 -0500
- Subject: Re: Fixes for mmix-knuth-mmixware
- Organization: Red Hat Inc.
- References: <Pine.BSF.4.30.0202112059280.51127-200000@dair.pair.com>
Hans-Peter Nilsson wrote:
>
> Hi. A few patches (attached) for:
> - Framework bugs, needs _link and should define _times, not times (a bug
> in common with other targets, it seems).
> - Trying to handle file append completely wrong (there's actually no
> support for it in the simulator).
> - Missing __volatile__ on the value-returning asms for simulator calls
> made them disappear if the values weren't used. Bad if you expect some
> side-effect from them. :-)
>
> Can I please commit this? (Else please consider doing it for me.)
Done.
> Can I commit changes to the mmixware files in the future, without explicit
> approval?
>
Yes, assuming you already have write access.
> 2002-02-12 Hans-Peter Nilsson <hp@bitrange.com>
>
> * libc/sys/mmixware/link.c: New.
> * libc/sys/mmixware/sys/syscall.h (TRAP1i, I3f): Make asm
> volatile.
> * libc/sys/mmixware/times.c (_times): Renamed from times.
> * libc/sys/mmixware/open.c (_open): Attempt to handle O_APPEND
> properly by reading previous contents, not through BinaryReadWrite.
> * libc/sys/mmixware/Makefile.am (lib_a_SOURCES): Add link.c
> * libc/sys/mmixware/Makefile.in: Regenerate.
>
> (Nag: don't forget to regenerate libc/sys/mmixware/Makefile.in. ;-)
>
Done.
-- Jeff J.