This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgloss/arm: isatty [PATCH]

Hi Shaun,

2005-07-28 Shaun Jackman <sjackman@gmail.com>

* libgloss/arm/libcfunc.c (isatty): New function.

This looks fine to me, so I can recommend that Jeff accepts it.

+	/* GDB does not yet support the IsTTY SWI that _isatty
+	 * calls, so always return true for now. */

                                                 ^
Minor point: You should have two spaces at the   |  end of a comment.

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]