This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: libgloss/arm: isatty [PATCH]
- From: jjohnstn <jjohnstn at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Shaun Jackman <sjackman at gmail dot com>, <newlib at sources dot redhat dot com>
- Date: Tue, 2 Aug 2005 15:32:50 -0400 (EDT)
- Subject: Re: libgloss/arm: isatty [PATCH]
Patch checked in with extra comment space added.
-- Jeff J.
On Fri, 29 Jul 2005, Nick Clifton wrote:
> Hi Shaun,
>
> > 2005-07-28 Shaun Jackman <sjackman@gmail.com>
> >
> > * libgloss/arm/libcfunc.c (isatty): New function.
>
> This looks fine to me, so I can recommend that Jeff accepts it.
>
> > + /* GDB does not yet support the IsTTY SWI that _isatty
> > + * calls, so always return true for now. */
> ^
> Minor point: You should have two spaces at the | end of a comment.
>
> Cheers
> Nick
>
>