Re: [patch][rfc] New Target: Toshiba Media Processor

[Jeff Johnston <jjohnstn at redhat dot com>]

Patches checked in.  You didn't include a change to README so I made one 
for you.  I also modified the licenses to reformat them <= 80 columns. 
I have subsequently reformatted the original Red Hat COPYING.LIBGLOSS 
entry you used as the basis.  Please ensure I didn't make any typos.

-- Jeff J.

Dave Brolley wrote:
> Hi Jeff,
>
> Thanks for looking at this code.
>
> As Red Hat does own the code in question, I have changed the copyright 
> and licensing to the Red Hat BSD-style license from COPYING.LIBGLOSS.
>
> There were two files which had GPL licensing. Both indicated that they 
> had been copied from gcc/libgcc2.c, however it it was only the copyright 
> and licensing that were copied. The remainder of the code in those files 
> bears no relation to any code in gcc/libgcc2.c. These have also been 
> changed to use the BSD-style copyright/license.
>
> You will find the updated files in the attached tar ball.
>
> Thanks,
> Dave
>
> Jeff Johnston wrote:
> > Dave.
> >
> > There are a few problems, one major.
> >
> > The major problem is that one of your pieces of code has a GPL license 
> > in it.  This is not acceptable in newlib/libgloss.  If Red Hat is the 
> > owner of the code, consider changing the license to the default Red 
> > Hat  BSD-style license which you should be able to find in 
> > COPYING.LIBGLOSS.
> >
> > By default, pieces of code without a specific license fall under the 
> > COPYING.LIBGLOSS Red Hat clause.  If any of the code has been 
> > contributed by Toshiba, you need to license it properly and get their 
> > permission.  It would be advisable to actually put the Red Hat license 
> > into anything contributed by Red Hat (i.e. not just defaulted).  This 
> > will avoid any confusion in the future.
> >
> > -- Jeff J.
> >
> > Dave Brolley wrote:
> > > Hi,
> > >
> > > On behalf of Red Hat and Toshiba, I would like to contribute libgloss 
> > > support for the Toshiba Media Processor (MeP). Please see the 
> > > attached patch and tarball.
> > >
> > > This port had been supported by Red Hat and available from Toshiba 
> > > since 2001. Toshiba has now given us permission to contribute it to 
> > > the public repository.
> > >
> > > In addition to contributing this code, I am also offering to maintain 
> > > it.
> > >
> > > Seeking approval to commit.
> > >
> > > Dave
> > >
> > >
> > > ------------------------------------------------------------------------
> > >
> > > 2007-02-05  Dave Brolley  <brolley@redhat.com>
> > >
> > >     * mep: New target directory.
> > >     * README: Add MeP.
> > >     * configure.in: Add support for MeP.
> > >     * configure: Regenerated.
> > >
> > >
> > > ------------------------------------------------------------------------
> > >
> > > Index: libgloss/configure.in
> > > ===================================================================
> > > RCS file: /cvs/src/src/libgloss/configure.in,v
> > > retrieving revision 1.21
> > > diff -c -p -r1.21 configure.in
> > > *** libgloss/configure.in    18 Dec 2006 21:48:18 -0000    1.21
> > > --- libgloss/configure.in    5 Feb 2007 19:05:41 -0000
> > > *************** case "${target}" in
> > > *** 104,109 ****
> > > --- 104,113 ----
> > >       AC_CONFIG_SUBDIRS(mcore)
> > >       config_testsuite=true
> > >       ;;
> > > +   mep-*-*)
> > > +     AC_CONFIG_SUBDIRS(mep)
> > > +     config_testsuite = true;
> > > +     ;;
> > >     mt-*-*)
> > >           AC_CONFIG_SUBDIRS(mt)
> > >       config_testsuite=true