This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH RFC] spu return rc value from __send_to_ppe
- From: Patrick Mansfield <patmans at us dot ibm dot com>
- To: Kazunori Asayama <asayama at sm dot sony dot co dot jp>
- Cc: newlib at sourceware dot org, Ulrich dot Weigand at de dot ibm dot com, vzbarsky at us dot ibm dot com
- Date: Tue, 22 May 2007 08:36:58 -0700
- Subject: Re: [PATCH RFC] spu return rc value from __send_to_ppe
- References: <20070521181533.GA19954@us.ibm.com> <20070522.180639.21207052.asayama@echo.sm.sony.co.jp>
On Tue, May 22, 2007 at 06:06:39PM +0900, Kazunori Asayama wrote:
> Patrick Mansfield <patmans@us.ibm.com> wrote:
> > Per Ulrich Weigand's suggestion, return the rc value in __send_to_ppe,
> > rather than doing so in each each caller of __send_to_ppe, so no code is
> > generated to return the value (since the return value is already in
> > register 3).
> >
> > This moves 8 bytes (2 instructions) from the caller into __send_to_ppe. So
> > to see any savings in size, you have to call two different assist calls.
>
> Sounds good.
>
> Here are my minor comments:
OK, thanks for the review, I'll post an update with changes per all of
your comments.
-- Patrick Mansfield