This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add open_wmemstream


On Feb 18 12:06, Jeff Johnston wrote:
> Corinna Vinschen wrote:
>> On Feb 17 20:05, Eric Blake wrote:
>>> According to Corinna Vinschen on 2/17/2009 10:22 AM:
>>>> I have added open_wmemstream per SUSv4 to the newlib implementation of
>>>> open_memstream.
>>>> [...]
>>> If wchar_t is 16 bits (as on cygwin), these last two fields occupy 64
>>> bits.  I suggest using 'char wide' instead, since it reduces the size
>>> requirement to 32 bits.
>>
>> Thanks for the hint.  I changed the type of wide to int8_t in my local
>> patch.
>>   
>>> Beyond that, the patch looked fine to me.
>>
>> Thanks for the review.
>>
>> Jeff, ok to apply?
>>   
> Yes, please go ahead and thanks.

Thanks, applied.  Did you have a chance to review the patches in
http://sources.redhat.com/ml/newlib/2009/msg00132.html and
http://sources.redhat.com/ml/newlib/2009/msg00145.html?


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]