This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
RE: isnanf cleanup
Ping.
(http://sourceware.org/ml/newlib/2009/msg00724.html for the attachment.)
-----Original Message-----
From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]
On Behalf Of Howland Craig D (Craig)
Sent: Friday, June 19, 2009 8:39 PM
To: Newlib
Subject: isnanf cleanup
The attached path (with ChangeLog) does the following:
Summary:
Cleans up isnanf use.
Applies some of the same improvements made in math.h on 2009-06-16 to
parallel macros defined in libc/include/machine/ieeefp.h, removing
un-necessary extension use.
Details on isnanf stuff:
Apparently, when the C99 isnan macro was added to math.h, some of the
associated cleanups were missed. The intent stated in comments in
math.h and some of the source files in libm is that the old isnan()
and isinf() functions were to be removed from math.h and put into
ieeefp.h to keep them available for legacy use. The isnanf() and
isinff() forms do not get completely cleaned up at that time. This
patch finishes that cleanup, removing those two prototypes from math.h
(leaving them in ieeefp.h). Since some source in libm/math called
isnanf() directly, they were edited to use the new isnan() macro,
instead. (The double forms of the function got the macro when the
change was first made since the name was the same as the old double
function form, so only float funtions were affected. The "isnanf"
calls could just as easily been changed to "__isnanf", but I chose
isnan to use the more portable form.)
(As before, I have not done anything with some files under mathfp that
have similar issues since mathfp has been abandoned.)
Craig