This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] _fflush_r check seek result fix


On Oct 29 15:59, Jeff Johnston wrote:
> On 29/10/09 06:24 AM, Corinna Vinschen wrote:
> >On Oct 28 11:56, Jeff Johnston wrote:
> >>I think you need to ignore the EINVAL regardless as it doesn't
> >>indicate the seek had a failure as much as ESPIPE doesn't.
> >
> >Ok, no worries, but in that case it doesn't make sense to avoid offsets
> ><  0.  This case is sufficiently covered by checking for EINVAL.  Patch
> >below.
> >
> 
> Looks fine.  Feel free to commit.

Done, thank you.  Additionally I expanded the comment

  /* Seek successful.  We can clear read buffer now.  */

to

  /* Seek successful or ignorable error condition.
     We can clear read buffer now.  */

to be more clear.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]