[patch,complex] Replace hard-coded constants

Ralf Corsepius ralf.corsepius@rtems.org
Fri Nov 26 09:00:00 GMT 2010


Hi,

The functions in ctan.c, ctanf.c, catan.c and catanf.c apply hard-coded 
constants which are out of range (i.e. they cause compilation warnings 
and likely will cause run-time failures) on some (e.g. 16bit) targets 
and likely are incorrect on all targets.

The patch below tries to replace these hard-coded constants with 
[FLT|DBL_MAX] from <float.h>, when these defines are available and tries 
to fall back to the original constants if these are not available.

Ralf

PS.: IMO, due to the fact <float.h> and [FLT|DBL]_MAX are POSIX and thus 
should be available in any current compiler, it's likely safe to 
completely remove the hard-coded constants and to directly use 
[FLT|DBL]_MAX.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: newlib-complex-ctan.diff
URL: <http://sourceware.org/pipermail/newlib/attachments/20101126/08e9748b/attachment.ksh>


More information about the Newlib mailing list