This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Fix undefined behaviour in lround,llround.

On Jul 1 06:38, Corinna Vinschen wrote: 

>On Jul 17 18:16, Dave Korn wrote:
>>   Same changelog as before.  OK now/with/without above-mentioned
minor
>> alterations?
>
>The reason not to use `unsigned long long tmp' sounds good to me.
>Keeping the SAFE_LEFT_SHIFT in the header doesn't hurt and might come
in
>handy at one point.  So, yes, that looks ok to apply, Dave, especially
>with the annotations (which should be mentioned in the ChangeLog).

Dave:
 
Looks good to me, too.
 
Adding the annotations makes very good sense, as insufficient comments
are part of the reason that most of the math functions are so hard to
maintain.
 
Craig
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]