Re: patch to add C99 complex

[Marco Atzeri <marco_atzeri at yahoo dot it>]

--- Mer 6/10/10, Marco Atzeri? ha scritto:

> --- Mer 6/10/10, Corinna
> Vinschen? ha scritto:
> 
> > Hi Marco,
> > 
> > On Oct? 6 07:54, Marco Atzeri wrote:
> > > The attached patch add C99 Complex to newlib
> > > using all NETBSD source except "long double"
> ones.
> > 
> > Thanks for the patch.? It's nice to get the C99
> > complex functions into
> > newlib.? However, here's a question:
> > 
> > The cabs{f}, carg{f} functions are using the GCC
> extensions
> > __real__ and
> > __imag__.? Other functions are calling the official
> > creal{f} and
> > cimag{f} functions.? AFAICS cabs{f} and carg{f}
> should
> > do the same.
> > Would you mind to fix this?
> 
> let me check
> 
> > 
> > Oh, and, please, when you send a patch, send it
> > uncompressed.? If it
> > doesn't fit into one mail, split it.? 
> 
> 109 K just a bit over the limit
>? 
> > And please, send
> > the ChangeLog
> > entry as is, always separate from the actual patch in
> your
> > mail.? A
> > patch of a ChangeLog entry almost never applies
> cleanly, so
> > the patch of
> > it has not much value.
> 
> no problem. It is just my first patch here.
> > 
> > 
> > Thanks,
> > Corinna
> > 
> 
> Marco
> 

one further question, should I include also the new
Makefile.in in addition to the Makefile.am ?

I just noticed that I need to run autoreconf on
newlib/libm
to generate the updated Makefile.in

autoreconf on newlib root seems incomplete.

$ autoreconf
autoheader-2.67: WARNING: Using auxiliary files such as `acconfig.h', `config.h.            bot'
autoheader-2.67: WARNING: and `config.h.top', to define templates for `config.h.            in'
autoheader-2.67: WARNING: is deprecated and discouraged.
autoheader-2.67:
autoheader-2.67: WARNING: Using the third argument of `AC_DEFINE' and
autoheader-2.67: WARNING: `AC_DEFINE_UNQUOTED' allows one to define a template w            ithout
autoheader-2.67: WARNING: `acconfig.h':
autoheader-2.67:
autoheader-2.67: WARNING:   AC_DEFINE([NEED_FUNC_MAIN], 1,
autoheader-2.67:                [Define if a function `main' is needed.])
autoheader-2.67:
autoheader-2.67: WARNING: More sophisticated templates can also be produced, see             the
autoheader-2.67: WARNING: documentation.
autoheader-2.67: warning: missing template: _WANT_REGISTER_FINI
autoheader-2.67: Use AC_DEFINE([_WANT_REGISTER_FINI], [], [Description])
autoreconf-2.67: /usr/bin/autoheader-2.67 failed with exit status: 1


Marco