This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
RE: PATCH: Support armv6-m in libgloss
- From: "Bin Cheng" <bin dot cheng at arm dot com>
- To: "'Jeff Johnston'" <jjohnstn at redhat dot com>, <newlib at sources dot redhat dot com>
- Cc: <nickc at redhat dot com>
- Date: Wed, 6 Jul 2011 10:47:37 +0800
- Subject: RE: PATCH: Support armv6-m in libgloss
- References: <4e09a8e7.04af2a0a.4540.5dd4SMTPIN_ADDED@mx.google.com> <BANLkTinCsztsMiN66XbrhEER2p8YWQD6bg@mail.gmail.com> <003101cc3a2d$df111600$9d334200$@cheng@arm.com> <4E13304D.8080608@redhat.com>
> -----Original Message-----
> From: Jeff Johnston [mailto:jjohnstn@redhat.com]
> Sent: Tuesday, July 05, 2011 11:40 PM
> To: Bin Cheng
> Cc: newlib@sources.redhat.com; nickc@redhat.com
> Subject: Re: PATCH: Support armv6-m in libgloss
>
> On 07/04/2011 05:36 AM, Bin Cheng wrote:
> Generally you post to the mailing list. In most cases, Corinna and
> myself review patches and there are a number of others who are
> well-versed in many areas of newlib who will comment when they see
> issues or have concerns.
>
> In this case, I am not an arm expert and the code is shared by a large
> number of configurations so it is real easy to cause breakage. This
> change modifies code in the shared path so I defer to the arm experts
> to
> comment. Nick is one of them and you cc'd him from the start.
>
> When a patch receives no comment, the right thing to do is what you
> have
> done and to ping the list. CC'ing others who have committed changes in
> the same area is a good idea as well which you have done.
>
> I will try to contact Nick directly and ask if he is available to
> review
> the patch.
>
> Regards,
>
> -- Jeff J.
Thanks very much for helping, Jeff. It's very helpful.
Thanks-chengbin