This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch alt 4/4] wordexp: avoid strdup and cleanup memory handling

From: Peter Rosin <peda at lysator dot liu dot se>
To: newlib at sourceware dot org
Date: Mon, 17 Sep 2012 10:27:10 +0200
Subject: Re: [patch alt 4/4] wordexp: avoid strdup and cleanup memory handling
References: <20120913230454.392673700@lysator.liu.se> <20120914162035.451437100@lysator.liu.se>

On 2012-09-14 19:36, Peter Rosin wrote:
> 2012-09-14  Peter Rosin  <peda@lysator.liu.se>
> 
> 	* libc/posix/wordfree.c (wordfree): The wrong words are freed
> 	when WRDE_DOOFFS is in use. Restructure the code so that the memory
> 	needed to be freed is instead kept in an internal linked list...
> 	* libc/posix/wordexp2.h: ...as defined here...
> 	* libc/posix/wordfree.c (wordfree): ...and build this internal

Should have been s/wordfree/wordexp/g on the above line.

> 	linked list here, avoiding wasteful strdup calls in the process.

And sorry for all the noise on the wordexp subject, I'll try to shut up now.

Cheers,
Peter

References:
- [patch 0/4] wordexp bug fixes and cleanups
  - From: Peter Rosin
- [patch alt 4/4] wordexp: avoid strdup and cleanup memory handling
  - From: Peter Rosin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]