This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: pthread.h: Add missing PTHREAD_RWLOCK_INITIALIZER
- From: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- To: Ralf Corsepius <ralf dot corsepius at rtems dot org>
- Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>
- Date: Mon, 12 Nov 2012 11:52:51 -0600
- Subject: Re: pthread.h: Add missing PTHREAD_RWLOCK_INITIALIZER
- References: <50A12FAE.5040303@oarcorp.com> <50A13560.5040801@rtems.org>
On 11/12/2012 11:44 AM, Ralf Corsepius wrote:
On 11/12/2012 06:19 PM, Joel Sherrill wrote:
Hi
Attached is a very simple 1 line patch which adds the
missing constant PTHREAD_RWLOCK_INITIALIZER and
makes it have the same value as the other similar
constants.
OK to commit?
No.
And can you explain why adding an accidentally missing constant
that is defined by Open Group gets a simple "No"
http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_rwlock_init.html
This is added in the same style as the other PTHREAD_XXX_INITIALIZER
values and its absence has just been overlooked.
2012-11-12 Joel Sherrill <joel.sherrill@oarcorp.com>
* libc/include/pthread.h: Add PTHREAD_RWLOCK_INITIALIZER.
Is it your intention to initialize to -1?
If so, initialization to 0xffffffff would not return -1 on platforms
with size > 32 bit.
Also, your construct would fail on platforms with sizeof(ptr) < 32bit.
Ralf
--
Joel Sherrill, Ph.D. Director of Research& Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985