This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [patch, mips] Fix parallel build on MIPS
- From: Steve Ellcey <sellcey at mips dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: <newlib at sourceware dot org>
- Date: Tue, 3 Sep 2013 11:17:08 -0700
- Subject: Re: [patch, mips] Fix parallel build on MIPS
- Authentication-results: sourceware.org; auth=none
- References: <cfe7a72d-3a40-48b3-82d9-85df5aa6c513 at BAMAIL02 dot ba dot imgtec dot org> <201309011505 dot 29936 dot vapier at gentoo dot org> <1378227500 dot 5770 dot 214 dot camel at ubuntu-sellcey> <201309031337 dot 33839 dot vapier at gentoo dot org> <1378230736 dot 5770 dot 224 dot camel at ubuntu-sellcey>
On Tue, 2013-09-03 at 10:52 -0700, Steve Ellcey wrote:
> On Tue, 2013-09-03 at 13:37 -0400, Mike Frysinger wrote:
>
> > > --- a/libgloss/mips/Makefile.in
> > > +++ b/libgloss/mips/Makefile.in
> > >
> > > install:
> > > + mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
> > > @for file in $(CRT0) $(PCRT0) $(BSP); do \
> >
> > this does not work because "@for" is not a shell command. the @ needs to move
> > from the for to the mkdir.
> > -mike
>
> Hm, I thought it would work because I see it in the mn10300 Makefile.in
> file. My own rebuild hasn't gotten to the point of install yet so we
> will see what happens when it does.
>
> Steve Ellcey
> sellcey@mips.com
OK, I think I understand now. We can leave the '@' on the for
if we don't put a '; \' at the end of the mkdir (because then
they are separate shell commands).
I am testing this now:
diff --git a/libgloss/mips/Makefile.in b/libgloss/mips/Makefile.in
index 2042e48..d96478d 100644
--- a/libgloss/mips/Makefile.in
+++ b/libgloss/mips/Makefile.in
@@ -201,8 +201,9 @@ distclean maintainer-clean realclean: clean
.PHONY: install info install-info clean-info
install:
+ mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}
@for file in $(CRT0) $(PCRT0) $(BSP); do \
- $(INSTALL_DATA) $${file} $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
+ $(INSTALL_DATA) $${file} $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}/$${file}; \
done
@for script in ${SCRIPTS}; do\
$(INSTALL_DATA) ${srcdir}/$${script}.ld $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}/$${script}.ld; \