This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, mips] Fix parallel build on MIPS


On Tue, 2013-09-03 at 10:52 -0700, Steve Ellcey wrote:
> On Tue, 2013-09-03 at 13:37 -0400, Mike Frysinger wrote:
> 
> > > --- a/libgloss/mips/Makefile.in
> > > +++ b/libgloss/mips/Makefile.in
> > > 
> > >  install:
> > > +	mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
> > >  	@for file in $(CRT0) $(PCRT0) $(BSP); do \
> > 
> > this does not work because "@for" is not a shell command.  the @ needs to move 
> > from the for to the mkdir.
> > -mike
> 
> Hm, I thought it would work because I see it in the mn10300 Makefile.in
> file.  My own rebuild hasn't gotten to the point of install yet so we
> will see what happens when it does.
> 
> Steve Ellcey
> sellcey@mips.com

OK, I think I understand now.  We can leave the '@' on the for
if we don't put a '; \' at the end of the mkdir (because then
they are separate shell commands).

I am testing this now:


diff --git a/libgloss/mips/Makefile.in b/libgloss/mips/Makefile.in
index 2042e48..d96478d 100644
--- a/libgloss/mips/Makefile.in
+++ b/libgloss/mips/Makefile.in
@@ -201,8 +201,9 @@ distclean maintainer-clean realclean: clean
 
 .PHONY: install info install-info clean-info
 install:
+	mkdir -p $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}
 	@for file in $(CRT0) $(PCRT0) $(BSP); do \
-	  $(INSTALL_DATA) $${file} $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}; \
+	  $(INSTALL_DATA) $${file} $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}/$${file}; \
 	done
 	@for script in ${SCRIPTS}; do\
 	  $(INSTALL_DATA) ${srcdir}/$${script}.ld $(DESTDIR)$(tooldir)/lib${MULTISUBDIR}/$${script}.ld; \




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]