This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Sebastian's Patches Committed

From: Ralf Corsepius <ralf dot corsepius at rtems dot org>
To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>, sebastian dot huber at embedded-brains dot de
Cc: joel dot sherrill at oarcorp dot com, newlib at sourceware dot org, chrisj at rtems dot org
Date: Sat, 26 Oct 2013 04:03:15 +0200
Subject: Re: Sebastian's Patches Committed
Authentication-results: sourceware.org; auth=none
References: <201310251513 dot r9PFDCkD002276 at ignucius dot se dot axis dot com>

On 10/25/2013 05:13 PM, Hans-Peter Nilsson wrote:

More imagination needed!

1. Use <stdint.h> from GCC and do this consistently, or

What do you mean by consistently?  Using it within compiled code
in newlib, yes.  Leaking stdint.h by using it *in installed
newlib headers* is a bug, not consistency.  The identifier
leakage is an actual bug, as opposed to the fixed wart of not
actually using the gcc stdint.h within newlib.

So, I suggest that patch be reverted but I'm open to:

I don't like Sebastian's patch, either, but haven't actually tested ityet, to have a strong opinion about it.

2. do not use <stdint.h> from GCC and define the type system on our own.

3. derive the internal definitions from gcc stdint.h.

There is another option: derive newlib's types from GCC internal typeswhen possible and fall back to using heuristics when GCC's internaltypes are not available. This is what newlib had done before Sebastian'spatches.


Ralf

References:
- Re: Sebastian's Patches Committed
  - From: Hans-Peter Nilsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]