This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: getopt changes

From: Freddie Chopin <freddie_chopin at op dot pl>
To: newlib at sourceware dot org
Date: Wed, 13 Nov 2013 20:47:38 +0100
Subject: Re: getopt changes
Authentication-results: sourceware.org; auth=none
References: <1384249946-17437-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20131112113134 dot GD427 at calimero dot vinschen dot de> <5283CC80 dot 6000507 at comcast dot net> <5283D1B5 dot 8030200 at op dot pl> <20131113193859 dot GA1775 at calimero dot vinschen dot de>

W dniu 2013-11-13 20:38, Corinna Vinschen pisze:

On Nov 13 20:23, Freddie Chopin wrote:

W dniu 2013-11-13 20:01, Gregory Pietsch pisze:

I noticed a few braces were omitted in the last version of getopt. Here
is the file with them added. -- Gregory


OMG, you're right (; Sorry about that... If necessary I can provide
a patch for these 4 braces only, as the file you posted has some
whitespace changes too.


Yes, please.

Patch attached. I don't know how about the changelog entry - it'sGregory who spotted the bug, so he should get the credit - I'd prefer toput him as the author, so you're free to change the text below.


newlib/ChangeLog
2013-11-13  Freddie Chopin  <freddie_chopin@op.pl>

	* newlib/libc/stdlib/getopt.c (getopt_internal): Add missing
	braces

Attachment: 0001-newlib-libc-stdlib-getopt.c-getopt_internal-add-miss.patch
Description: Text document

Follow-Ups:
- Re: getopt changes
  - From: Corinna Vinschen

References:
- [PATCH] Fix NULL pointer access in getopt_internal()
  - From: Sebastian Huber
- Re: [PATCH] Fix NULL pointer access in getopt_internal()
  - From: Corinna Vinschen
- getopt changes
  - From: Gregory Pietsch
- Re: getopt changes
  - From: Freddie Chopin
- Re: getopt changes
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]