This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch - Add C99 restrict to iconv.h


On Nov 19 19:03, Joel Sherrill wrote:
> Hi
> 
> This is the first restrict patch via Google Code-In.
> 
> It is another in the series to add the __restrict keyword.
> 
> Is this OK to commit?

Basically, yes, just...

> 2013-11-19  Daniel Ramirez <...>
> 
> 	* libc/iconv/lib/iconv.c, libc/include/iconv.h,
> 	libc/sys/linux/iconv/iconv.c: Add restrict keyword.
> [...]
> Index: newlib/libc/include/iconv.h
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/include/iconv.h,v
> retrieving revision 1.3
> diff -u -r1.3 iconv.h
> --- newlib/libc/include/iconv.h	21 Aug 2009 20:27:10 -0000	1.3
> +++ newlib/libc/include/iconv.h	20 Nov 2013 00:12:38 -0000
> @@ -41,7 +41,10 @@
>  _EXFUN(iconv_open, (_CONST char *, _CONST char *));
>  
>  size_t
> -_EXFUN(iconv, (iconv_t, char **, size_t *, char **, size_t *));
> +_EXFUN(iconv, (iconv_t, char **__restrict,
> +               size_t *__restrict, 
> +               char **__restrict, 
> +               size_t *__restrict));

...this could be a bit more compact:

  _EXFUN(iconv, (iconv_t, char **__restrict, size_t *__restrict,
		 char **__restrict, size_t *__restrict));


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpUPiE_FvVbD.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]