This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Patch - Add restrict to sys/time.h
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: newlib at sourceware dot org
- Date: Fri, 22 Nov 2013 19:44:47 -0500 (EST)
- Subject: Re: Patch - Add restrict to sys/time.h
- Authentication-results: sourceware.org; auth=none
- References: <528FDE8E dot 9000807 at oarcorp dot com> <528FE03F dot 3070105 at oarcorp dot com>
Please go ahead.
Regarding _gettimeofday, leave it alone at least for now. Looking at glibc,
gettimeofday uses restrict, but __gettimeofday does not nor do
a number of the internal routines AFAICT from the git tree.
-- Jeff J.
----- Original Message -----
From: "Joel Sherrill" <joel.sherrill@oarcorp.com>
To: newlib@sourceware.org
Sent: Friday, November 22, 2013 5:52:47 PM
Subject: Re: Patch - Add restrict to sys/time.h
There is a typo in this patch. See v2 attached.
Is v2 OK to commit?
And .. v1 accidentally changed _gettimeofday to
gettimeofday in the prototype. Which makes me
ask if the system call _gettimeofday should
have restrict added?
It appears in 44 files in libgloss and libc
if that helps the decision.
On 11/22/2013 4:45 PM, Joel Sherrill wrote:
> Hi
>
> Another in the adding restrict keyword series from
> Google Code-In Students.
>
> OK to commit?
>
> 2013-11-22 Bryan Dunsmore <dunsmoreb@gmail.com>
>
> * libc/include/sys/time.h (gettimeofday): Add restrict keyword.
> (setitimer): Likewise.
> * libc/sys/rdos/gettod.c (gettimeofday): Likewise.
> * libc/sys/rtems/crt0.c (gettimeofday): Likewise.
>
>
--
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985