This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch - Add restrict to time.h


On 11/25/2013 11:45 AM, Joel Sherrill wrote:
On 11/25/2013 10:41 AM, Howland Craig D (Craig) wrote:
        * libc/time/strftime.c (strftime): Same.
-	size_t strftime(char *<[s]>, size_t <[maxsize]>,
-			const char *<[format]>, const struct tm
*<[timp]>);
+	size_t strftime(char *restrict<[s]>, size_t <[maxsize]>,
+			const char *restrict<[format]>,
+                        const struct tm *restrict<[timp]>);

  The strftime patch for the man page is missing spaces between restrict
and the respective pointers, which will make it very hard to read.
Craig

So change "restrict<[s]>" to "restrict <[s]>"?
Yes.

If that's the pattern, grep says iconv.c also needs fixing.

If you can confirm that, I will fix those instances.

Thanks.


Yes, iconv.c also needs to be tweaked (I missed that one earlier). (The "<[string]>" construct ends up making "string" bold in the PDF version of the manual, but no other alteration. So, for example, "char *restrict<[s]>," becomes "char *restricts," instead of the desired "char *restrict s,".)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]