This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Define _sbrk, read, _write as weak symbols
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: Newlib Mailing List <newlib at sourceware dot org>
- Cc: Joey Ye <joey dot ye at arm dot com>, Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Date: Tue, 11 Feb 2014 14:56:01 -0500 (EST)
- Subject: Re: [PATCH] Define _sbrk, read, _write as weak symbols
- Authentication-results: sourceware.org; auth=none
- References: <000001cf23de$76aa5520$63feff60$ at arm dot com> <CAFqB+PwOPcK4oZZ7uZS6U3PjNGW_hV+uS43Ew7SLTHWweOD2YA at mail dot gmail dot com>
Patch applied.
-- Jeff J.
----- Original Message -----
From: "Marcus Shawcroft" <marcus.shawcroft@gmail.com>
To: "Joey Ye" <joey.ye@arm.com>
Cc: "Newlib Mailing List" <newlib@sourceware.org>
Sent: Tuesday, February 11, 2014 9:53:20 AM
Subject: Re: [PATCH] Define _sbrk, read, _write as weak symbols
On 7 February 2014 08:27, Joey Ye <joey.ye@arm.com> wrote:
> Users sometimes redefines _sbrk, _read and _write but would like to use
> other functions in rdimon. This patch defines them weak symbols to avoid
> multiple definition linker errors.
>
> Joey Ye <joey.ye@arm.com>
>
> ChangeLog.newlib:
> libc/sys/arm/syscalls.c (_sbrk): Define as weak symbols.
> (_read, _write): Ditto.
>
> ChangeLog.libgloss:
> arm/syscalls.c (_sbrk): Define as weak symbols.
> (_read, _write): Ditto.
Looks sensible to me, but I can;t approve.
/Marcus