This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Remaining arch issue in Newlib optimized ARM ASM memchr for Cortex-R
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Nicholas Clifton <nickc at redhat dot com>
- Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>, Pavel Pisa <ppisa4lists at pikron dot com>, rtems-devel <rtems-devel at rtems dot org>, Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- Date: Thu, 03 Jul 2014 13:49:21 +0100
- Subject: Re: Remaining arch issue in Newlib optimized ARM ASM memchr for Cortex-R
- Authentication-results: sourceware.org; auth=none
- References: <201407030216 dot 43438 dot ppisa4lists at pikron dot com> <53B549E1 dot 1020207 at redhat dot com>
On 03/07/14 13:17, Nicholas Clifton wrote:
> Hi Jeff,
>
> > Pavel Pisa wrote:
>> Index: newlib-2.1/newlib/libc/machine/arm/memchr.S
>> ===================================================================
>> --- newlib-2.1.orig/newlib/libc/machine/arm/memchr.S 2011-10-18 13:35:17.000000000 +0200
>> +++ newlib-2.1/newlib/libc/machine/arm/memchr.S 2014-07-03 00:38:47.598049234 +0200
>> @@ -46,7 +46,11 @@
>> @ tidy
>>
>> .syntax unified
>> +#ifdef __ARM_ARCH_7R__
>> + .arch armv7-r
>> +#else
>> .arch armv7-a
>> +#endif
>>
>> #include "arm_asm.h"
>
> This patch looks good to me.
>
> Cheers
> Nick
>
>
>
Not quite. It's better than what's already there, but misses the
ARMv6t2 case -- see a couple of lines later. I think a simple change to
.arch armv6t2
should handle all v7-a and v7-r cases.
R.