This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Add missing strerror() strings, clean up
- From: Craig Howland <howland at LGSInnovations dot com>
- To: newlib at sourceware dot org
- Date: Thu, 10 Jul 2014 12:55:36 -0400
- Subject: Re: [PATCH] Add missing strerror() strings, clean up
- Authentication-results: sourceware.org; auth=none
- References: <1404987975 dot 51912 dot 5 dot camel at nehalem dot solo dot local>
On 07/10/2014 06:26 AM, Nick Withers wrote:
Hi all,
The attached patch:
- Adds to strerror()'s strerror.c strings for:
...
- Changes the following comments in errno.h to match the implementation:
...
- EDOM, from "Math arg out of domain of func" to "Math
argument" (would "Mathematics argument out of domain of function" or
"Mathematical (...)" be better?)
"Math argument" would be a step backwards. If it were to be changed at all, use
the POSIX "Mathematics argument out of domain of function." (The existing is
POSIX with 3 abbreviations, and really could be left as-is.)
...
P.S.: Should EMFILE's "Too many open files" actually be "File descriptor
value too large"? ENFILE's for the former, I think? Perhaps they're one
and the same in Newlib :-)
The description ought to match POSIX, so , yes, EMFILE ought to change. (It
appears to only be used in 1 place (libc/machine/spu/stdio.c), where it is not
entirely clear with a cursory examination whether it is being used properly or not.)
Craig