Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"

[Jeff Johnston <jjohnstn at redhat dot com>]

The change has been made.  Hopefully, this time I finally got it right.

-- Jeff J.

----- Original Message -----
From: "Freddie Chopin" <freddie_chopin@op.pl>
To: newlib@sourceware.org
Sent: Monday, September 15, 2014 10:20:28 AM
Subject: Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"

W dniu 2014-09-13 09:00, Freddie Chopin pisze:
> W dniu 2014-09-12 23:43, Jeff Johnston pisze:
>> Yes...I didn't look at the fix-up patch closely.  Fixed.  Thanks.
>
> You took both missing files (month_lengths.c and tzcalc_limits.c) from
> the first version of patch, so that's the reason for the above problem.
> But that's not the only problem - the problematic array has old name
> "month_lengths", not "__month_lengths".
>
> I compile-checked that (with a call to localtime(), to actually pull the
> relevant code in the link) and it seems to be the last problem. I attach
> patch with a changelog.
>
> Are patches in git format a problem to apply on CVS repo?

I'm pinging about the patch I posted on Friday, as the problem now is 
hidden - newlib will compile fine, but any application which would 
actually need this array would fail to link, there will be no previous 
indication of the problem.

Regards,
FCh