Re: [PATCH] unlocked stdio extensions

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Yaakov,

On Dec 15 13:24, Yaakov Selkowitz wrote:
> This is a first draft of an implementation of the 19 unlocked stdio
> extensions:
> 
> http://man7.org/linux/man-pages/man3/unlocked_stdio.3.html
> 
> These are used most notably by GCC when available.
> 
> There are a few points that could use clarification:
> 
> * are there any CHECK_INITs that are missing or unnecessary in these
> functions?

The rules for using CHECK_INIT or _REENT_SMALL_CHECK_INIT should be
the same as for the non-unlocked functions.

> * should the documentation of the _unlocked variants be separate, or merged
> with the locking variants (as the _r variants do)?

Good question.  The existing POSIX-compatible unlocked functions have
separate documentation.  If you move the unlocked over into the non
unlocked man pages, you will have to do that for the unlocked POSIX
variations as well.

In theory we could follow the Linux man page layout.  On Linux the
unlocked functions just have a single man page, pointing out non-
thread-safety and (non-}standardness and otherwise pointing to their
non-unlocked counterparts for the description.

What's missing in your patch are the _r variations of the functions.
They are provided by the POSIX-compatible unlocked functions and they
should be available for the non-comaptible versions as well.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpUF3stuY68m.pgp
Description: PGP signature