This is the mail archive of the
rda@sources.redhat.com
mailing list for the rda project.
RFA: emit semicolon in 'p' packet reply only if more regs to come
- From: Jim Blandy <jimb at redhat dot com>
- To: rda at sources dot redhat dot com
- Date: 07 Oct 2004 17:43:17 -0500
- Subject: RFA: emit semicolon in 'p' packet reply only if more regs to come
2004-10-07 Jim Blandy <jimb@redhat.com>
* lib/gdbserv-state.c (do_get_registers_p_packet): Don't produce a
';' trailing the register value unless there are more register
values to come. This makes the multi-register packet
upward-compatible with the single-register request / reply
expected by GDB.
Index: rda/lib/gdbserv-state.c
===================================================================
RCS file: /cvs/src/src/rda/lib/gdbserv-state.c,v
retrieving revision 1.3
diff -c -p -r1.3 gdbserv-state.c
*** rda/lib/gdbserv-state.c 9 Jul 2004 20:00:25 -0000 1.3
--- rda/lib/gdbserv-state.c 7 Oct 2004 22:41:38 -0000
*************** do_get_registers_p_packet (struct gdbser
*** 605,617 ****
result = "E02";
break;
}
- gdbserv_output_string (gdbserv, ";");
if (gdbserv_input_string_match (gdbserv, ";") < 0)
{
if (gdbserv_input_size (gdbserv) > 0)
result = "E03";
break;
}
}
if (result != NULL)
{
--- 605,617 ----
result = "E02";
break;
}
if (gdbserv_input_string_match (gdbserv, ";") < 0)
{
if (gdbserv_input_size (gdbserv) > 0)
result = "E03";
break;
}
+ gdbserv_output_string (gdbserv, ";");
}
if (result != NULL)
{