This is the mail archive of the
rda@sourceware.org
mailing list for the rda project.
Re: changes in 'intl'
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org, Steve Ellcey <sje at cup dot hp dot com>, gdb-patches at sourceware dot org, rda at sourceware dot org
- Date: Fri, 23 Jun 2006 15:33:12 +0930
- Subject: Re: changes in 'intl'
- References: <4475B7AD.46E1073E@dessent.net> <20060525144537.GA1017@nevyn.them.org> <20060525174240.GA5632@nevyn.them.org> <20060525224932.GA12464@nevyn.them.org> <20060531153301.GA17450@nevyn.them.org>
On Wed, May 31, 2006 at 11:33:02AM -0400, Daniel Jacobowitz wrote:
> Index: binutils/ChangeLog
> 2006-05-31 Daniel Jacobowitz <dan@codesourcery.com>
>
> * Makefile.am: Replace INTLLIBS with LIBINTL everywhere. Add
> DEPENDENCIES variables for every program.
This results in libbfd, libopcodes, and libiberty dependencies being
omitted. If you specify *_DEPENDENCIES variables, they need to list
*all* dependencies. A similar problem occurs if you try to add empty
rules for the exe files like
addr2line$(EXEEXT): $(LIBINTL_DEP)
ar$(EXEEXT): $(LIBINTL_DEP)
..
Automake then decides not to add its own rules. :-(
This patch isn't very nice, but I'm not inclined to delve into automake
to find a more elegant solution.
* Makefile.am (*_DEPENDENCIES): Add missing dependencies.
* Makefile.in: Regenerate.
Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.74
diff -u -p -r1.74 Makefile.am
--- binutils/Makefile.am 31 May 2006 15:14:35 -0000 1.74
+++ binutils/Makefile.am 23 Jun 2006 05:52:18 -0000
@@ -182,24 +182,24 @@ installcheck:
# There's no global DEPENDENCIES. So, we must explicitly list everything
# which depends on libintl, since we don't know whether LIBINTL_DEP will be
# non-empty until configure time. Ugh!
-size_DEPENDENCIES = $(LIBINTL_DEP)
-objdump_DEPENDENCIES = $(LIBINTL_DEP)
-nm_new_DEPENDENCIES = $(LIBINTL_DEP)
-ar_DEPENDENCIES = $(LIBINTL_DEP)
-strings_DEPENDENCIES = $(LIBINTL_DEP)
-strip_new_DEPENDENCIES = $(LIBINTL_DEP)
-ranlib_DEPENDENCIES = $(LIBINTL_DEP)
-cxxfilt_DEPENDENCIES = $(LIBINTL_DEP)
-objcopy_DEPENDENCIES = $(LIBINTL_DEP)
-nlmconv_DEPENDENCIES = $(LIBINTL_DEP)
-srconv_DEPENDENCIES = $(LIBINTL_DEP)
-sysdump_DEPENDENCIES = $(LIBINTL_DEP)
-coffdump_DEPENDENCIES = $(LIBINTL_DEP)
-dlltool_DEPENDENCIES = $(LIBINTL_DEP)
-windres_DEPENDENCIES = $(LIBINTL_DEP)
-addr2line_DEPENDENCIES = $(LIBINTL_DEP)
-readelf_DEPENDENCIES = $(LIBINTL_DEP)
-dllwrap_DEPENDENCIES = $(LIBINTL_DEP)
+size_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+objdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) $(OPCODES)
+nm_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+ar_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+strings_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+strip_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+ranlib_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+cxxfilt_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+objcopy_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+nlmconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+srconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+sysdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+coffdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+dlltool_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+windres_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+addr2line_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+readelf_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY)
+dllwrap_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY)
LDADD = $(BFDLIB) $(LIBIBERTY) $(LIBINTL)
--
Alan Modra
IBM OzLabs - Linux Technology Centre