This is the mail archive of the systemtap-cvs@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.7-162-gb9aa5bb


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "systemtap: system-wide probe/trace tool".

The branch, master has been updated
       via  b9aa5bb4e52a16ba405996cafe9394ca9466c76c (commit)
       via  d61ea6024b0a465f786b11122c5bc73a11f84a93 (commit)
       via  1af73aa2e762248bd9bb66f64fbb7fc814b2d5f5 (commit)
       via  15553cabf1eac4b894ee17f8165a70577cc2acd1 (commit)
       via  36eb80f35d651e93a5f0120e828566e3b6d06dfc (commit)
      from  cc0901e06ffd9b0c156d399d80f3c92479c0477c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b9aa5bb4e52a16ba405996cafe9394ca9466c76c
Author: Josh Stone <jistone@redhat.com>
Date:   Thu Apr 12 12:59:50 2012 -0700

    Synchronize class/struct declarations
    
    We are not very consistent about choosing struct vs class types, and in
    some cases we have a mismatch between declaration and definition of a
    given type.  Gcc doesn't care, but clang -Wall complains:
    
      CXX    stap-main.o
    In file included from ../main.cxx:12:
    ../staptree.h:489:1: error: struct 'vardecl' was previously declared
            as a class [-Werror,-Wmismatched-tags]
    struct vardecl: public symboldecl
    ^~~~~~
    class
    ../staptree.h:218:7: note: previous use is here
    class vardecl;
          ^
    
    In all cases, I left the definition alone, and adjusted the declaration
    to match, so it should be semantically unchanged.

commit d61ea6024b0a465f786b11122c5bc73a11f84a93
Author: Josh Stone <jistone@redhat.com>
Date:   Thu Apr 12 12:51:24 2012 -0700

    sdt_query: initialize probe_type/loc as unknown.
    
    The fields, probe_type and probe_loc, are meaningless to start, and are
    later set as the queried module is examined.  Commit 74fe61bc tried to
    make sure that all POD types in this class are initialized, but these
    two were essentially self-assigned.  Gcc misses this uninitialized use,
    but clang caught it:
    
      CXX    stap-tapsets.o
    ../tapsets.cxx:6058:38: error: field is uninitialized when used here [-Werror,-Wuninitialized]
      base_query(dw, params), probe_type(probe_type), probe_loc(probe_loc), base_probe(base_probe),
                                         ^
    ../tapsets.cxx:6058:61: error: field is uninitialized when used here [-Werror,-Wuninitialized]
      base_query(dw, params), probe_type(probe_type), probe_loc(probe_loc), base_probe(base_probe),
                                                                ^
    
    Values for "unknown" are now added to these enum types to initialize
    with, and dealt with where needed.

commit 1af73aa2e762248bd9bb66f64fbb7fc814b2d5f5
Author: Josh Stone <jistone@redhat.com>
Date:   Thu Apr 12 12:46:00 2012 -0700

    stapsh: convert dbug macros to void statements
    
    This is to get around a clang warning:
    
       CC     stapsh-stapsh.o
     ../../../runtime/staprun/stapsh.c:241:3: error: expression result
         unused [-Werror,-Wunused-value]
       vdbug (1, format, dbug_args);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ../../../runtime/staprun/stapsh.c:100:58: note: instantiated from:
     #define vdbug(level, format, args) ( (verbose < level) ? 0 : \
                                                              ^
    
    None of the dbug/vdbug callers care about the fprintf return values,
    so just squash them and move on.

commit 15553cabf1eac4b894ee17f8165a70577cc2acd1
Author: Josh Stone <jistone@redhat.com>
Date:   Thu Apr 12 12:35:25 2012 -0700

    dwflpp: Mark loc2c_error as noreturn
    
    Clang complains thusly:
    
    ../dwflpp.cxx:2281:15: error: no matching function for call to
          'c_translate_constant'
          *tail = c_translate_constant (pool, &loc2c_error, this,
                  ^~~~~~~~~~~~~~~~~~~~
    In file included from ../dwflpp.cxx:54:
    ../loc2c.h:46:18: note: candidate function not viable: no known
          conversion from 'void (*)(void *, const char *, ...)' to
          'void (*)(void *, const char *, ...) __attribute__((noreturn))'
          for 2nd argument
    struct location *c_translate_constant (struct obstack *,
                     ^
    
    The declaration for loc2c_error just needs the matching attribute.

commit 36eb80f35d651e93a5f0120e828566e3b6d06dfc
Author: Josh Stone <jistone@redhat.com>
Date:   Thu Apr 12 12:26:41 2012 -0700

    csclient: check directly for negative IPv4 pieces
    
    As noted by clang, the code was looking for negative values of an
    unsigned variable (which was read by strtoul).
    
      CXX    stap-csclient.o
    ../csclient.cxx:2638:44: error: comparison of unsigned expression < 0
          is always false [-Werror,-Wtautological-compare]
          if (errno != 0 || *estr != '\0' || p < 0 || p > 255)
                                             ~ ^ ~
    
    This can never be negative, but strtoul will implicitly case negative-
    looking strings to unsigned, which will make them fail p > 255 anyway.
    But to be more direct, switch to [signed] long and use strtol.

-----------------------------------------------------------------------

Summary of changes:
 csclient.cxx             |    2 +-
 dwflpp.h                 |    2 +-
 elaborate.h              |    4 ++--
 runtime/staprun/stapsh.c |   14 ++++++++------
 sdt_types.h              |    3 ++-
 session.h                |    6 +++---
 staptree.h               |    4 ++--
 tapsets.cxx              |   10 +++++++---
 translate.cxx            |    4 ++--
 9 files changed, 28 insertions(+), 21 deletions(-)


hooks/post-receive
--
systemtap: system-wide probe/trace tool


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]