This is the mail archive of the
systemtap@sources.redhat.com
mailing list for the systemtap project.
Re: [PATCH] (updated) Allow a jprobe to coexist with kprobes
- From: Maneesh Soni <maneesh at in dot ibm dot com>
- To: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- Cc: "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>, Ananth N Mavinakayanahalli <amavin at redhat dot com>, SystemTAP <systemtap at sources dot redhat dot com>
- Date: Tue, 17 May 2005 11:01:30 +0530
- Subject: Re: [PATCH] (updated) Allow a jprobe to coexist with kprobes
- References: <44BDAFB888F59F408FAE3CC35AB4704101A3AB08@orsmsx409> <20050516215703.GA5044@in.ibm.com>
- Reply-to: maneesh at in dot ibm dot com
On Mon, May 16, 2005 at 05:57:03PM -0400, Ananth N Mavinakayanahalli wrote:
> On Mon, May 16, 2005 at 02:18:59PM -0700, Keshavamurthy, Anil S wrote:
> > Hi Ananth,
> > Your patch does not compile on x86_64, see below.
> >
> > + } else {
> > + if (p->break_handler &&
> > + p->break_handler(p,
> > regs)) {
> >
> > ^^^^^^^
> > You have an extra open bracket with out the matching close bracket.
> >
> > I will update you how the testing goes( with the above compile fix)
> > soon.
>
> Thanks for catching this Anil! I need to be more careful with this,
> especially the ones I can't compile test.
>
I guess it is good idea to crosscompile if a patch has arch dependent code.
There are cross-compile tools available at
http://developer.osdl.org/dev/plm/cross_compile/
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: maneesh@in.ibm.com
Phone: 91-80-25044990