This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: seek for matching patches!
- From: Ananth N Mavinakayanahalli <amavin at redhat dot com>
- To: l ss <suansuan412 at hotmail dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Tue, 06 Sep 2005 09:36:23 -0400
- Subject: Re: seek for matching patches!
- References: <BAY12-F4B95E9A5E77FEF4FAA5E6F8A30@phx.gbl>
l ss wrote:
>
>
>
> Ananth wrote:
>
>>> That version was an older take. The latest changeset is under
>>
>> patches/kprobes-use-rcu/. Also note that the kprobes patches are
>> normally diffed against the mainline and not the FC kernels. In most
>> directories under patches/, a README in the directory tells which
>> kernel/mm the diff is against.
>>
>
> I apply the patches under patches/kprobes-use-rcu in order on two
> os(linux-2.6.12 and linux-2.6.13), but I can't succeed either!
>
> on linux-2.6.12
> [root@lss linux]# patch -p1 <
> /root/systemtap/patches/kprobes-use-rcu/kp-preempt-i386.patch
> patching file arch/i386/kernel/kprobes.c
> Hunk #1 succeeded at 102 (offset -56 lines).
> Hunk #2 succeeded at 230 (offset -6 lines).
> Hunk #3 FAILED at 303.
> Hunk #4 succeeded at 313 with fuzz 1 (offset -136 lines).
> Hunk #5 succeeded at 492 with fuzz 2 (offset -6 lines).
> 1 out of 5 hunks FAILED -- saving rejects to file
> arch/i386/kernel/kprobes.c.rej
>
>
>
> on linux-2.6.13
> [root@lss linux]# patch -p1 <
> /root/systemtap/patches/kprobes-use-rcu/kp-pcpu-i386.patch
> patching file arch/i386/kernel/kprobes.c
> Hunk #3 succeeded at 152 (offset -1 lines).
> Hunk #5 succeeded at 183 (offset -1 lines).
> Hunk #7 succeeded at 231 (offset -1 lines).
> Hunk #9 FAILED at 337.
> Hunk #10 succeeded at 347 (offset -1 lines).
> Hunk #12 succeeded at 430 (offset -1 lines).
> Hunk #14 succeeded at 496 (offset -1 lines).
> Hunk #15 FAILED at 505.
> 2 out of 15 hunks FAILED -- saving rejects to file
> arch/i386/kernel/kprobes.c.rej
> patching file include/asm-i386/kprobes.h
>
>
>
> Please answer me two questiones:
> no.1 Which kernel have you succeeded in applying the patches?
Patches are against 2.6.13-rc5-mm1. This is mentioned in the README in
the directory, as I had indicated above.
no.2 Are
> these patches under patches/kprobes-use-rcu necessary for kprob?
No, these aren't required to run normal kprobes. We are working on these
patches to improve the speed of kprobe handling on SMP.
Ananth