This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 1/3] Kprobes: userspace probes new interfaces


Hi Frank,

On Wed, Sep 14, 2005 at 11:18:18AM -0400, Frank Ch. Eigler wrote:
> 
> prasanna wrote:
> 
> > [...]
> > 	struct uprobe {
> > 		char name[50]; 
> > [...]
> 
> (There must be a more appropriate limit than the literal 50.)
> 

How about user module allocating the the string for the pathname and
passing the pointer to the uprobe structure and with this now we will have

	struct uprobe {
		char *pathname;
> 
> > [...]
> > User has to allocate uprobes structure and initialize following 
> > elements
> > 	name		- contains the path of the application;
> > 	offset		- offset of the probe within the page;
> > 	kp.addr 	- virtual address within the executable.
> > [...]
> 
> Why both "offset" and "kp.addr" ?
> 

Offset can be derived from kp.addr, 
I will remove the offset from uprobe structure.

Thanks
Prasanna
-- 

Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@in.ibm.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]