This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH]Systemtap IA64 Runtime support
On Fri, Oct 28, 2005 at 03:33:32PM -0400, Frank Ch. Eigler wrote:
> Not at all - just that Red Hat should have already been there too. If
> you were so kind as to add it, that would be great.
Sure, not a problem, I will add it.
> I guess it comes down testing it - whichever works should stay. How
> many of the pass-4 / pass-5 tests have you been able to run? Also,
> have you tested systemtap on a plain x86 after your changes, just to
> make sure that the base port was not affected?
Almost all of my changes are under #if defined (__ia64__) but definitely
before check in, I will make sure I test it on i386 once again.
BTW, I tested manually by writing some tap scripts, which covered
most of the stuff like, printing function args, stack dump, function probe,
return probe etc. Also with the make check, it reported 2 of 103 tests failed.
Can you please elaborate if there are any other standard tests
that I should be running?
>
> Do you already have physical CVS write privileges? If so, you could
> commit.
Yes, I have and will check it in.
thanks,
Anil