This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [Patch 2/3][Djprobe] Djprobe update for linux-2.6.14-mm1
- From: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- To: "Zhang, Yanmin" <yanmin dot zhang at intel dot com>
- Cc: systemtap at sources dot redhat dot com, Satoshi Oshima <soshima at redhat dot com>, Yumiko Sugita <sugita at sdl dot hitachi dot co dot jp>, Hideo Aoki <haoki at redhat dot com>, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>
- Date: Tue, 22 Nov 2005 22:04:04 +0900
- Subject: Re: [Patch 2/3][Djprobe] Djprobe update for linux-2.6.14-mm1
- References: <8126E4F969BA254AB43EA03C59F44E8403DB7B23@pdsmsx404>
Hi, Zhang
I am sorry to reply so late.
Zhang, Yanmin wrote:
> [YM] It's reasonable. In function register_kprobe,
Thanks.
> 1) get_djprobe_instance should be __get_djprobe_instance if djprobe_mutex is used.
Exactly. I missed it.
> 2) Release djprobe_mutex before " return -EEXIST".
Thanks to find that!
> 3) Parameter size of call to get_djprobe_instance is always 1 here. How about to change it to ARCH_STUB_INSN_MAX?
> One more comment on your 3rd patch, how about to change:
> +#define ARCH_STUB_SIZE ((long)&arch_tmpl_stub_end - (long)&arch_tmpl_stub_entry)
> to
> +#define ARCH_STUB_SIZE (((long)&arch_tmpl_stub_end - (long)&arch_tmpl_stub_entry)/sizeof(kprobe_opcode_t))
>
> On ia32, sizeof(kprobe_opcode_t) is equal to 1, but on other platform, it might not be. Just to make it clearer.
>
OK, I will change it as like that.
Best Regards,
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp