This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Review patches of user space kprobe


> >>> are only executed after the loop of hlist_for_each_entry. Is it correct?
> >>>
> >>
> >>that's correct. The page is mapped only once for the first match in the loop,
> >>then all the probes are inserted into that page in the hlist_for_each loop and
> >>then the page is unmapped only once after the end of the loop.
> So call lock_page for many times, and call unlock_page for one time?
> 
no, lock_page and unlock_page is called only once, there is a small correction, 
insert_probe_page() should be moved out of if condition so that all probes
are inserted on that page.

Thanks
Prasanna
-- 
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-25044636


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]