This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug runtime/2497] STP_STRING_SIZE set by stap is too small
- From: "hunt at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 31 Mar 2006 17:49:09 -0000
- Subject: [Bug runtime/2497] STP_STRING_SIZE set by stap is too small
- References: <20060330093952.2497.guanglei@cn.ibm.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From hunt at redhat dot com 2006-03-31 17:49 -------
If you use backtrace(), it puts it's results in a string, so MAXSTRINGLEN must
be adjusted.
If you use print_backtrace() it writes the output directly to stdout so there is
no limit. EXCEPT I see the ppc64 __stp_stack_sprint() function has put an
incorrect limit there. Perhaps that is the real problem you are trying to fix?
If you want to fix that function, consider that if "str == _stp_stdout" then the
output is going to the output buffer, not a string of size STP_STRING_SIZE. Also
it looks like this backtrace function loops until it has filled up the output
buffer, not finished the backtrace, which is a very bad idea, especially because
it is not clear to me this won't loop forever in some cases.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=2497
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.