Re: [PATCH] Kprobe:multi kprobe posthandler for booster

[Prasanna S Panchamukhi <prasanna at in dot ibm dot com>]

Hi Andrew,

Please find the details below.

On Wed, Apr 26, 2006 at 02:55:08PM -0700, Andrew Morton wrote:
> "mao, bibo" <bibo.mao@intel.com> wrote:
> >
> >   If there are multi kprobes on the same probepoint, there
> > will be one extra aggr_kprobe on the head of kprobe list.
> > The aggr_kprobe has aggr_post_handler/aggr_break_handler
> > whether the other kprobe post_hander/break_handler is NULL
> > or not. This patch modifies this, only when there is one or
> > more kprobe in the list whose post_handler is not NULL, 
> > post_handler of aggr_kprobe will be set as aggr_post_handler.
> 
> OK...  But you didn't provide me with sufficient information with which I
> can gauge the seriousness of this problem.  Show-stopper bug?  Minor
> performance problem?  Hard to tell, and I do need that information to be
> able to judge whether patches should do into -rc or into the next kernel
> cycle, as well as being backported into -stable.
> 

Yes, sorry for not providing enough information.

> I currently have four patches:
> 
> kprobe-boost-2byte-opcodes-on-i386.patch
> kprobe-fix-resume-execution-on-i386.patch
> kprobemulti-kprobe-posthandler-for-booster.patch
> kprobe-cleanup-for-vm_mask-judgement.patch
> 
> I _think_ the first two are 2.6.17 material and the latter two are 2.6.18
> material.  Could others please comment?

kprobe-cleanup-for-vm_mask-judgement.patch
This patch is a minor cleanup patch and can go into 2.6.17.

kprobe-fix-resume-execution-on-i386.patch
This patch is a minor bug fix and can go into 2.6.17. This patch
needs to be reviewed and tested before it can make into the mainline.

kprobe-boost-2byte-opcodes-on-i386.patch
kprobemulti-kprobe-posthandler-for-booster.patch
These two patches solve minor performance problem and can go into 2.6.18, but
they need more reivew and testing before they can make into mainline.

Also the patches does not contain enough explanation, hence request
all of you to provide more explanation along with the patch.

Plesae let me know if you need more information.

Thanks
Prasanna
-- 
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-41776329